kadu/gotify-android-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash on share when not loggedin

Browse Source 
java.lang.RuntimeException:
      at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2957)
      at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3032)
      at android.app.ActivityThread.-wrap11 (Unknown Source)
      at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1696)
      at android.os.Handler.dispatchMessage (Handler.java:105)
      at android.os.Looper.loop (Looper.java:164)
      at android.app.ActivityThread.main (ActivityThread.java:6944)
      at java.lang.reflect.Method.invoke (Native Method)
      at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:327)
      at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1374)
    Caused by: java.lang.IllegalArgumentException:
      at okhttp3.HttpUrl$Builder.parse (HttpUrl.java:1333)
      at okhttp3.HttpUrl.get (HttpUrl.java:916)
      at retrofit2.Retrofit$Builder.baseUrl (Retrofit.java:458)
      at com.github.gotify.api.ClientFactory.defaultClient (ClientFactory.java:47)
      at com.github.gotify.api.ClientFactory.clientToken (ClientFactory.java:28)
      at com.github.gotify.sharing.ShareActivity.onCreate (ShareActivity.java:82)
      at android.app.Activity.performCreate (Activity.java:7183)
      at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1220)
      at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2910)
This commit is contained in:
Jannis Mattheis
2022-01-09 15:17:32 +01:00
parent 2a72853f13
commit 0f008acb7f
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/com/github/gotify/sharing/ShareActivity.java
View File

@@ -78,6 +78,13 @@ public class ShareActivity extends AppCompatActivity {
} }
} }
if (!settings.tokenExists()) {
Toast.makeText(getApplicationContext(), R.string.not_loggedin_share, Toast.LENGTH_SHORT)
.show();
finish();
return;
}
ApiClient client = ApiClient client =
ClientFactory.clientToken(settings.url(), settings.sslSettings(), settings.token()); ClientFactory.clientToken(settings.url(), settings.sslSettings(), settings.token());
appsHolder = new ApplicationHolder(this, client); appsHolder = new ApplicationHolder(this, client);

1
app/src/main/res/values/strings.xml
View File

@@ -83,4 +83,5 @@
<string name="push_priority_hint">Priority</string> <string name="push_priority_hint">Priority</string>
<string name="push_missing_app_info">There are no applications available on the server to push a message to.</string> <string name="push_missing_app_info">There are no applications available on the server to push a message to.</string>
<string name="message_copied_to_clipboard">Content copied to clipboard</string> <string name="message_copied_to_clipboard">Content copied to clipboard</string>
<string name="not_loggedin_share">Cannot share to Gotify, because you aren\'t logged in.</string>
</resources> </resources>