From 21383fba1b25dcb1e3e0a2530be6132d6136c34b Mon Sep 17 00:00:00 2001 From: Jannis Mattheis Date: Mon, 6 Feb 2023 13:13:45 +0100 Subject: [PATCH] Use data class --- .../gotify/messages/provider/MessageImageCombiner.kt | 9 +-------- .../github/gotify/messages/provider/MessageWithImage.kt | 8 ++++---- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/app/src/main/kotlin/com/github/gotify/messages/provider/MessageImageCombiner.kt b/app/src/main/kotlin/com/github/gotify/messages/provider/MessageImageCombiner.kt index 24f02bd..b5d2750 100644 --- a/app/src/main/kotlin/com/github/gotify/messages/provider/MessageImageCombiner.kt +++ b/app/src/main/kotlin/com/github/gotify/messages/provider/MessageImageCombiner.kt @@ -6,14 +6,7 @@ import com.github.gotify.client.model.Message internal object MessageImageCombiner { fun combine(messages: List, applications: List): List { val appIdToImage = appIdToImage(applications) - val result = mutableListOf() - messages.forEach { - val messageWithImage = MessageWithImage() - messageWithImage.message = it - messageWithImage.image = appIdToImage[it.appid] - result.add(messageWithImage) - } - return result + return messages.map { MessageWithImage(message = it, image = appIdToImage[it.appid]) } } fun appIdToImage(applications: List): Map { diff --git a/app/src/main/kotlin/com/github/gotify/messages/provider/MessageWithImage.kt b/app/src/main/kotlin/com/github/gotify/messages/provider/MessageWithImage.kt index 951c654..9d1c293 100644 --- a/app/src/main/kotlin/com/github/gotify/messages/provider/MessageWithImage.kt +++ b/app/src/main/kotlin/com/github/gotify/messages/provider/MessageWithImage.kt @@ -2,7 +2,7 @@ package com.github.gotify.messages.provider import com.github.gotify.client.model.Message -internal class MessageWithImage { - lateinit var message: Message - var image: String? = null -} +internal data class MessageWithImage( + val message: Message, + val image: String? +)