diff --git a/app/src/main/java/com/github/gotify/api/ClientFactory.java b/app/src/main/java/com/github/gotify/api/ClientFactory.java
index be4c575..beaaf94 100644
--- a/app/src/main/java/com/github/gotify/api/ClientFactory.java
+++ b/app/src/main/java/com/github/gotify/api/ClientFactory.java
@@ -28,8 +28,7 @@ public class ClientFactory {
return client;
}
- public static ApiClient clientToken(
- String baseUrl, SSLSettings sslSettings, String token) {
+ public static ApiClient clientToken(String baseUrl, SSLSettings sslSettings, String token) {
ApiClient client = unauthorized(baseUrl, sslSettings);
ApiKeyAuth tokenAuth = (ApiKeyAuth) client.getAuthentication("clientTokenHeader");
tokenAuth.setApiKey(token);
diff --git a/app/src/main/java/com/github/gotify/login/AdvancedDialog.java b/app/src/main/java/com/github/gotify/login/AdvancedDialog.java
index 38dea6a..f52fd1e 100644
--- a/app/src/main/java/com/github/gotify/login/AdvancedDialog.java
+++ b/app/src/main/java/com/github/gotify/login/AdvancedDialog.java
@@ -57,20 +57,20 @@ class AdvancedDialog {
new AlertDialog.Builder(context)
.setView(dialogView)
- .setTitle("Advanced Settings")
- .setPositiveButton("Done", (ignored, ignored2) -> {})
+ .setTitle(R.string.advanced_settings)
+ .setPositiveButton(context.getString(R.string.done), (ignored, ignored2) -> {})
.show();
return this;
}
private void showSelectCACertificate() {
- holder.toggleCaCert.setText("Select CA Certificate");
+ holder.toggleCaCert.setText(R.string.select_ca_certificate);
holder.toggleCaCert.setOnClickListener((a) -> onClickSelectCaCertificate.run());
- holder.selectedCaCertificate.setText("No certificate selected");
+ holder.selectedCaCertificate.setText(R.string.no_certificate_selected);
}
void showRemoveCACertificate(String certificate) {
- holder.toggleCaCert.setText("Remove CA Certificate");
+ holder.toggleCaCert.setText(R.string.remove_ca_certificate);
holder.toggleCaCert.setOnClickListener(
(a) -> {
showSelectCACertificate();
diff --git a/app/src/main/java/com/github/gotify/login/LoginActivity.java b/app/src/main/java/com/github/gotify/login/LoginActivity.java
index 1212098..2fce438 100644
--- a/app/src/main/java/com/github/gotify/login/LoginActivity.java
+++ b/app/src/main/java/com/github/gotify/login/LoginActivity.java
@@ -8,18 +8,14 @@ import android.os.Build;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
-import android.widget.CheckBox;
import android.widget.EditText;
import android.widget.ImageView;
-import android.widget.LinearLayout;
import android.widget.ProgressBar;
-import android.widget.TextView;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity;
import butterknife.BindView;
import butterknife.ButterKnife;
-import butterknife.OnCheckedChanged;
import butterknife.OnClick;
import butterknife.OnTextChanged;
import com.github.gotify.R;
@@ -58,24 +54,9 @@ public class LoginActivity extends AppCompatActivity {
@BindView(R.id.password)
EditText passwordField;
- @BindView(R.id.sslGroup)
- LinearLayout sslGroup;
-
@BindView(R.id.advanced_settings)
ImageView toggleAdvanced;
- @BindView(R.id.disableValidateSSL)
- CheckBox disableSSLValidationCheckBox;
-
- @BindView(R.id.or)
- TextView orTextView;
-
- @BindView(R.id.selectCACertificate)
- Button selectCACertificate;
-
- @BindView(R.id.caFile)
- TextView caFileName;
-
@BindView(R.id.checkurl)
Button checkUrlButton;
@@ -88,13 +69,10 @@ public class LoginActivity extends AppCompatActivity {
@BindView(R.id.login_progress)
ProgressBar loginProgress;
- private boolean showAdvanced = false;
-
private Settings settings;
private boolean disableSSLValidation;
private String caCertContents;
- private AlertDialog advancedSettingsDialog;
private AdvancedDialog advancedDialog;
@Override
@@ -116,6 +94,7 @@ public class LoginActivity extends AppCompatActivity {
usernameField.setVisibility(View.GONE);
passwordField.setVisibility(View.GONE);
loginButton.setVisibility(View.GONE);
+ checkUrlButton.setText(getString(R.string.check_url));
}
@OnClick(R.id.checkurl)
@@ -128,15 +107,13 @@ public class LoginActivity extends AppCompatActivity {
checkUrlProgress.setVisibility(View.VISIBLE);
checkUrlButton.setVisibility(View.GONE);
- sslGroup.setVisibility(View.GONE);
final String fixedUrl = url.endsWith("/") ? url.substring(0, url.length() - 1) : url;
Api.withLogging(
ClientFactory.versionApi(
fixedUrl,
- new SSLSettings(
- !disableSSLValidation, caCertContents))
+ new SSLSettings(!disableSSLValidation, caCertContents))
::getVersionAsync)
.handleInUIThread(this, onValidUrl(fixedUrl), onInvalidUrl(fixedUrl));
}
@@ -166,14 +143,7 @@ public class LoginActivity extends AppCompatActivity {
.show(disableSSLValidation, selectedCertName);
}
- @OnCheckedChanged(R.id.disableValidateSSL)
- void doChangeDisableValidateSSL(boolean disable) {
- // temporarily set the ssl validation (don't store to settings until they decide to login)
- disableSSLValidation = disable;
- }
-
- @OnClick(R.id.selectCACertificate)
- void doSelectCACertificate() {
+ private void doSelectCACertificate() {
Intent intent = new Intent(Intent.ACTION_OPEN_DOCUMENT);
// we don't really care what kind of file it is as long as we can parse it
intent.setType("*/*");
@@ -238,7 +208,6 @@ public class LoginActivity extends AppCompatActivity {
usernameField.requestFocus();
passwordField.setVisibility(View.VISIBLE);
loginButton.setVisibility(View.VISIBLE);
- sslGroup.setVisibility(View.VISIBLE);
};
}
@@ -246,7 +215,6 @@ public class LoginActivity extends AppCompatActivity {
return (exception) -> {
checkUrlProgress.setVisibility(View.GONE);
checkUrlButton.setVisibility(View.VISIBLE);
- sslGroup.setVisibility(View.VISIBLE);
Utils.showSnackBar(LoginActivity.this, versionError(url, exception));
};
}
@@ -258,7 +226,6 @@ public class LoginActivity extends AppCompatActivity {
loginButton.setVisibility(View.GONE);
loginProgress.setVisibility(View.VISIBLE);
- sslGroup.setVisibility(View.GONE);
ApiClient client =
ClientFactory.basicAuth(
@@ -273,7 +240,6 @@ public class LoginActivity extends AppCompatActivity {
private void onInvalidLogin(ApiException e) {
loginButton.setVisibility(View.VISIBLE);
loginProgress.setVisibility(View.GONE);
- sslGroup.setVisibility(View.VISIBLE);
Utils.showSnackBar(this, getString(R.string.wronguserpw));
}
@@ -312,13 +278,11 @@ public class LoginActivity extends AppCompatActivity {
Utils.showSnackBar(this, getString(R.string.create_client_failed));
loginProgress.setVisibility(View.GONE);
loginButton.setVisibility(View.VISIBLE);
- sslGroup.setVisibility(View.VISIBLE);
}
private void onCancelClientDialog(DialogInterface dialog, int which) {
loginProgress.setVisibility(View.GONE);
loginButton.setVisibility(View.VISIBLE);
- sslGroup.setVisibility(View.VISIBLE);
}
private String versionError(String url, ApiException exception) {
diff --git a/app/src/main/java/com/github/gotify/messages/MessagesActivity.java b/app/src/main/java/com/github/gotify/messages/MessagesActivity.java
index 134a3fd..eefa5bd 100644
--- a/app/src/main/java/com/github/gotify/messages/MessagesActivity.java
+++ b/app/src/main/java/com/github/gotify/messages/MessagesActivity.java
@@ -50,11 +50,10 @@ import com.squareup.okhttp.HttpUrl;
import com.squareup.picasso.OkHttp3Downloader;
import com.squareup.picasso.Picasso;
import com.squareup.picasso.Target;
-import okhttp3.OkHttpClient;
-
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
+import okhttp3.OkHttpClient;
import static java.util.Collections.emptyList;
@@ -184,9 +183,7 @@ public class MessagesActivity extends AppCompatActivity
OkHttp3Downloader downloader = new OkHttp3Downloader(builder.build());
- return new Picasso.Builder(this)
- .downloader(downloader)
- .build();
+ return new Picasso.Builder(this).downloader(downloader).build();
}
private void initDrawer() {
diff --git a/app/src/main/res/layout/activity_login.xml b/app/src/main/res/layout/activity_login.xml
index 3870b62..a090611 100644
--- a/app/src/main/res/layout/activity_login.xml
+++ b/app/src/main/res/layout/activity_login.xml
@@ -110,78 +110,6 @@
app:layout_constraintWidth_max="280dp"
tools:text="Password" />
-
-
-
-
-
-
-
-
-
-
-
-
-
+ android:text="@string/disabled_validate_ssl" />
+ android:text="@string/select_ca_certificate" />
-
\ No newline at end of file
+ android:text="@string/no_certificate_selected" />
+
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index ae86c0d..805b51d 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -35,10 +35,8 @@
Disable SSL Validation
Select CA Certificate
Select a Certificate File
- OR
Please install a file browser
Failed to read CA: %s
- No CA selected
Login
Check URL
gotify logo
@@ -52,4 +50,8 @@
Initializing
%s@%s
Gotify-Server v%s
+ Advanced Settings
+ Done
+ No certificate selected
+ Remove CA Certificate