From bb8273e29fd31f64e17847d26fbb5f4f87418da6 Mon Sep 17 00:00:00 2001 From: Niko Diamadis Date: Fri, 3 Feb 2023 11:16:01 +0100 Subject: [PATCH 01/12] Apply Material3 styles --- app/build.gradle | 2 +- app/src/main/res/values/styles.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index d9c17d7..63912ea 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -66,7 +66,7 @@ dependencies { implementation project(':client') implementation 'androidx.appcompat:appcompat:1.5.1' implementation 'androidx.core:core-splashscreen:1.0.0' - implementation 'com.google.android.material:material:1.4.0' + implementation 'com.google.android.material:material:1.7.0' implementation 'androidx.constraintlayout:constraintlayout:2.1.4' implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0' implementation 'androidx.vectordrawable:vectordrawable:1.1.0' diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index b8c79e1..e1a3dbb 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -1,7 +1,7 @@ - - - From d539ef8a76942fa91066cab39574554906cb0e7b Mon Sep 17 00:00:00 2001 From: Niko Diamadis Date: Fri, 3 Feb 2023 20:51:43 +0100 Subject: [PATCH 10/12] Update missed components --- .../com/github/gotify/messages/MessagesActivity.kt | 12 ++++++------ app/src/main/res/layout/activity_messages.xml | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/kotlin/com/github/gotify/messages/MessagesActivity.kt b/app/src/main/kotlin/com/github/gotify/messages/MessagesActivity.kt index c7b8fee..5b5704c 100644 --- a/app/src/main/kotlin/com/github/gotify/messages/MessagesActivity.kt +++ b/app/src/main/kotlin/com/github/gotify/messages/MessagesActivity.kt @@ -522,12 +522,12 @@ internal class MessagesActivity : } } if (item.itemId == R.id.action_delete_app) { - val alert = android.app.AlertDialog.Builder(this) - alert.setTitle(R.string.delete_app) - alert.setMessage(R.string.ack) - alert.setPositiveButton(R.string.yes) { _, _ -> deleteApp(viewModel.appId) } - alert.setNegativeButton(R.string.no, null) - alert.show() + MaterialAlertDialogBuilder(this) + .setTitle(R.string.delete_app) + .setMessage(R.string.ack) + .setPositiveButton(R.string.yes) { _, _ -> deleteApp(viewModel.appId) } + .setNegativeButton(R.string.no, null) + .show() } return super.onContextItemSelected(item) } diff --git a/app/src/main/res/layout/activity_messages.xml b/app/src/main/res/layout/activity_messages.xml index 955952c..ef9d826 100644 --- a/app/src/main/res/layout/activity_messages.xml +++ b/app/src/main/res/layout/activity_messages.xml @@ -62,11 +62,11 @@ From bb9f66b8d3ae1abcc7b64b0ea6a0d58533ae06fc Mon Sep 17 00:00:00 2001 From: Niko Diamadis Date: Sat, 4 Feb 2023 10:16:51 +0100 Subject: [PATCH 11/12] Fix messages not being selectable --- .../com/github/gotify/messages/ListMessageAdapter.kt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/src/main/kotlin/com/github/gotify/messages/ListMessageAdapter.kt b/app/src/main/kotlin/com/github/gotify/messages/ListMessageAdapter.kt index e36916d..15451ea 100644 --- a/app/src/main/kotlin/com/github/gotify/messages/ListMessageAdapter.kt +++ b/app/src/main/kotlin/com/github/gotify/messages/ListMessageAdapter.kt @@ -101,6 +101,13 @@ internal class ListMessageAdapter( return currentItem.message.id } + // Fix for message not being selectable (https://issuetracker.google.com/issues/37095917) + override fun onViewAttachedToWindow(holder: ViewHolder) { + super.onViewAttachedToWindow(holder) + holder.message.isEnabled = false + holder.message.isEnabled = true + } + class ViewHolder(binding: ViewBinding) : RecyclerView.ViewHolder(binding.root) { lateinit var image: ImageView lateinit var message: TextView From 5fa19e3b8818c3b7df6e2b1a5acdb7882db1aeab Mon Sep 17 00:00:00 2001 From: Niko Diamadis Date: Sat, 4 Feb 2023 10:57:22 +0100 Subject: [PATCH 12/12] Fix cancelable client name dialog --- app/src/main/kotlin/com/github/gotify/login/LoginActivity.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/kotlin/com/github/gotify/login/LoginActivity.kt b/app/src/main/kotlin/com/github/gotify/login/LoginActivity.kt index f46dd42..ac31707 100644 --- a/app/src/main/kotlin/com/github/gotify/login/LoginActivity.kt +++ b/app/src/main/kotlin/com/github/gotify/login/LoginActivity.kt @@ -248,6 +248,7 @@ internal class LoginActivity : AppCompatActivity() { .setView(clientDialogBinding.root) .setPositiveButton(R.string.create, doCreateClient(client, clientDialogEditext)) .setNegativeButton(R.string.cancel) { _, _ -> onCancelClientDialog() } + .setCancelable(false) .show() }