From ffd0ff4ad79938fe8a98ae0ba2ae12710c2673f9 Mon Sep 17 00:00:00 2001 From: "dries.k" Date: Sun, 21 Aug 2022 10:30:30 +0200 Subject: [PATCH] notification duration: instead of showing a tooltip, just hide the elements on windows --- gotify_tray/gui/designs/widget_settings.py | 2 +- gotify_tray/gui/designs/widget_settings.ui | 2 +- gotify_tray/gui/widgets/SettingsDialog.py | 9 ++++++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/gotify_tray/gui/designs/widget_settings.py b/gotify_tray/gui/designs/widget_settings.py index abbc233..3a0f95c 100644 --- a/gotify_tray/gui/designs/widget_settings.py +++ b/gotify_tray/gui/designs/widget_settings.py @@ -155,7 +155,7 @@ class Ui_Dialog(object): self.groupBox_notifications.setTitle(_translate("Dialog", "Notifications")) self.label_notification_duration_ms.setText(_translate("Dialog", "ms")) self.label_notification_priority.setText(_translate("Dialog", "Minimum priority to show notifications:")) - self.label_notification_duration.setText(_translate("Dialog", "

Notification duration [?]:

")) + self.label_notification_duration.setText(_translate("Dialog", "Notification duration:")) self.cb_notify.setText(_translate("Dialog", "Show a notification for missed messages after reconnecting")) self.groupBox_server_info.setTitle(_translate("Dialog", "Server info")) self.pb_change_server_info.setText(_translate("Dialog", "Change server info")) diff --git a/gotify_tray/gui/designs/widget_settings.ui b/gotify_tray/gui/designs/widget_settings.ui index c385c02..3f3579b 100644 --- a/gotify_tray/gui/designs/widget_settings.ui +++ b/gotify_tray/gui/designs/widget_settings.ui @@ -70,7 +70,7 @@ - <html><head/><body><p>Notification duration <span style=" font-weight:600; color:#0000ff;">[?]</span>:</p></body></html> + Notification duration: diff --git a/gotify_tray/gui/widgets/SettingsDialog.py b/gotify_tray/gui/widgets/SettingsDialog.py index 2c13d5f..0c98358 100644 --- a/gotify_tray/gui/widgets/SettingsDialog.py +++ b/gotify_tray/gui/widgets/SettingsDialog.py @@ -1,4 +1,5 @@ import logging +import platform import os import webbrowser @@ -46,9 +47,11 @@ class SettingsDialog(QtWidgets.QDialog, Ui_Dialog): self.spin_duration.setValue( settings.value("tray/notifications/duration_ms", type=int) ) - self.label_notification_duration.setToolTip( - "This setting is ignored on Windows." - ) + if platform.system() == "Windows": + # The notification duration setting is ignored by windows + self.label_notification_duration.hide() + self.spin_duration.hide() + self.label_notification_duration_ms.hide() self.cb_notify.setChecked( settings.value("message/check_missed/notify", type=bool)