From e2a3cf4c5dd1f8ef91d98e96128ff74c0a8ad1ec Mon Sep 17 00:00:00 2001 From: kdusek Date: Thu, 13 Nov 2025 17:55:06 +0100 Subject: [PATCH] Fix symlink creation issues and add installation verification checks for the installer scripts --- install-borg-cli.sh | 9 +++++++++ install-git-credential-manager.sh | 9 ++++++++- install-tea-cli.sh | 9 +++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/install-borg-cli.sh b/install-borg-cli.sh index f13c55f..fa09131 100755 --- a/install-borg-cli.sh +++ b/install-borg-cli.sh @@ -425,6 +425,15 @@ install_borg_from_binary() { # Install the binary with version suffix $install_cmd "$TEMP_DIR/$binary_name" "$TARGET_DIR/borg-$version" + # Verify installation + if [[ ! -f "$TARGET_DIR/borg-$version" ]]; then + print_error "Failed to install Borg CLI binary" + return 1 + fi + + # Remove any existing borg symlink or file to avoid conflicts + rm -f "$TARGET_DIR/borg" + # Create/update symlink to point to this version $symlink_cmd "$TARGET_DIR/borg-$version" "$TARGET_DIR/borg" diff --git a/install-git-credential-manager.sh b/install-git-credential-manager.sh index 9c1c3a3..cad284f 100755 --- a/install-git-credential-manager.sh +++ b/install-git-credential-manager.sh @@ -341,9 +341,16 @@ install_from_tarball() { cd "$extracted_dir" print_status "Installing binary to $INSTALL_DIR..." sudo install -m 755 git-credential-manager "$INSTALL_DIR/git-credential-manager" + + # Verify installation + if [[ ! -f "$INSTALL_DIR/git-credential-manager" ]]; then + print_error "Failed to install Git Credential Manager binary" + return 1 + fi + sudo ln -sf "$INSTALL_DIR/git-credential-manager" "$INSTALL_DIR/git-credential-manager-core" fi - + print_success "Binary installed successfully" } diff --git a/install-tea-cli.sh b/install-tea-cli.sh index 7f2b7dd..22bf61d 100755 --- a/install-tea-cli.sh +++ b/install-tea-cli.sh @@ -409,6 +409,15 @@ install_tea_from_binary() { # Install the binary with version suffix $install_cmd "$TEMP_DIR/$binary_name" "$TARGET_DIR/tea-$version" + # Verify installation + if [[ ! -f "$TARGET_DIR/tea-$version" ]]; then + print_error "Failed to install Tea CLI binary" + return 1 + fi + + # Remove any existing tea symlink or file to avoid conflicts + rm -f "$TARGET_DIR/tea" + # Create/update symlink to point to this version $symlink_cmd "$TARGET_DIR/tea-$version" "$TARGET_DIR/tea"